Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wait for state execution completion #345

Merged
merged 14 commits into from
Sep 18, 2023

Conversation

duoertai
Copy link
Collaborator

@duoertai duoertai commented Sep 11, 2023

not completed
TODO:
add state to wait for
add wait time in request
fix signal naming, etc
handle WaitForStateCompletion already running case

tested WaitForStateCompletion workflow and the api for happy case

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #345 (e1e4cb6) into main (fb2ba60) will increase coverage by 0.09%.
Report is 5 commits behind head on main.
The diff coverage is 79.78%.

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   72.57%   72.66%   +0.09%     
==========================================
  Files          56       56              
  Lines        4726     4870     +144     
==========================================
+ Hits         3430     3539     +109     
- Misses       1053     1077      +24     
- Partials      243      254      +11     
Files Changed Coverage Δ
service/interfaces.go 88.23% <ø> (ø)
service/interpreter/interfaces.go 73.33% <ø> (ø)
service/api/handler.go 53.61% <50.00%> (-0.48%) ⬇️
service/interpreter/cadence/workflowProvider.go 72.61% <71.42%> (-0.24%) ⬇️
service/interpreter/temporal/workflowProvider.go 74.33% <71.42%> (-0.26%) ⬇️
service/interpreter/activityImpl.go 82.20% <72.22%> (-0.23%) ⬇️
service/api/cadence/client.go 75.19% <75.75%> (-0.58%) ⬇️
service/api/temporal/client.go 72.04% <81.25%> (+0.50%) ⬆️
service/api/service.go 76.67% <83.78%> (+0.01%) ⬆️
service/api/routers.go 100.00% <100.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@longquanzheng longquanzheng changed the title add wait for workflow completion Support wait for state execution completion Sep 11, 2023
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add in activityImpl:

func StateApiExecute(...)
	defer func() {
		// if input.waiting { signalWithStart }
	}()

@duoertai duoertai force-pushed the add-wait-for-workflow-completion branch from f6578e3 to 3f847eb Compare September 13, 2023 23:02
@duoertai duoertai marked this pull request as ready for review September 16, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants