Skip to content

Commit

Permalink
IWF-105: Update IDL
Browse files Browse the repository at this point in the history
  • Loading branch information
lwolczynski committed Nov 14, 2024
1 parent 526a127 commit 6f2395e
Show file tree
Hide file tree
Showing 5 changed files with 60 additions and 30 deletions.
12 changes: 11 additions & 1 deletion gen/iwfidl/api/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3305,9 +3305,19 @@ components:
type: object
EventType:
enum:
- WORKFLOW_START_EVENT
- STATE_EXECUTE_ATTEMPT_FAIL_EVENT
- STATE_EXECUTE_ATTEMPT_SUCC_EVENT
- STATE_EXECUTE_E2E_COMPLETE_EVENT
- STATE_EXECUTE_E2E_FAIL_EVENT
- STATE_EXECUTE_E2E_START_EVENT
- STATE_WAIT_UNTIL_ATTEMPT_FAIL_EVENT
- STATE_WAIT_UNTIL_ATTEMPT_SUCC_EVENT
- STATE_WAIT_UNTIL_E2E_COMPLETE_EVENT
- STATE_WAIT_UNTIL_E2E_FAIL_EVENT
- STATE_WAIT_UNTIL_E2E_START_EVENT
- WORKFLOW_COMPLETE_EVENT
- WORKFLOW_FAIL_EVENT
- WORKFLOW_START_EVENT
type: string
IwfEvent:
properties:
Expand Down
26 changes: 23 additions & 3 deletions gen/iwfidl/docs/EventType.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,31 @@
## Enum


* `START_EVENT` (value: `"WORKFLOW_START_EVENT"`)
* `STATE_EXECUTE_ATTEMPT_FAIL_EVENT` (value: `"STATE_EXECUTE_ATTEMPT_FAIL_EVENT"`)

* `COMPLETE_EVENT` (value: `"WORKFLOW_COMPLETE_EVENT"`)
* `STATE_EXECUTE_ATTEMPT_SUCC_EVENT` (value: `"STATE_EXECUTE_ATTEMPT_SUCC_EVENT"`)

* `FAIL_EVENT` (value: `"WORKFLOW_FAIL_EVENT"`)
* `STATE_EXECUTE_E2_E_COMPLETE_EVENT` (value: `"STATE_EXECUTE_E2E_COMPLETE_EVENT"`)

* `STATE_EXECUTE_E2_E_FAIL_EVENT` (value: `"STATE_EXECUTE_E2E_FAIL_EVENT"`)

* `STATE_EXECUTE_E2_E_START_EVENT` (value: `"STATE_EXECUTE_E2E_START_EVENT"`)

* `STATE_WAIT_UNTIL_ATTEMPT_FAIL_EVENT` (value: `"STATE_WAIT_UNTIL_ATTEMPT_FAIL_EVENT"`)

* `STATE_WAIT_UNTIL_ATTEMPT_SUCC_EVENT` (value: `"STATE_WAIT_UNTIL_ATTEMPT_SUCC_EVENT"`)

* `STATE_WAIT_UNTIL_E2_E_COMPLETE_EVENT` (value: `"STATE_WAIT_UNTIL_E2E_COMPLETE_EVENT"`)

* `STATE_WAIT_UNTIL_E2_E_FAIL_EVENT` (value: `"STATE_WAIT_UNTIL_E2E_FAIL_EVENT"`)

* `STATE_WAIT_UNTIL_E2_E_START_EVENT` (value: `"STATE_WAIT_UNTIL_E2E_START_EVENT"`)

* `WORKFLOW_COMPLETE_EVENT` (value: `"WORKFLOW_COMPLETE_EVENT"`)

* `WORKFLOW_FAIL_EVENT` (value: `"WORKFLOW_FAIL_EVENT"`)

* `WORKFLOW_START_EVENT` (value: `"WORKFLOW_START_EVENT"`)


[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
Expand Down
28 changes: 24 additions & 4 deletions gen/iwfidl/model_event_type.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion iwf-idl
Submodule iwf-idl updated 1 files
+11 −1 iwf.yaml
22 changes: 1 addition & 21 deletions service/api/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,6 @@ func (s *serviceImpl) ApiV1WorkflowStartPost(
}
} else {
s.logger.Info("Started workflow", tag.WorkflowID(req.WorkflowId), tag.WorkflowRunID(runId))
logevent.Log(iwfidl.IwfEvent{
EventType: iwfidl.START_EVENT,
WorkflowType: "",
WorkflowId: "",
WorkflowRunId: "",
})
}

return &iwfidl.WorkflowStartResponse{
Expand Down Expand Up @@ -526,7 +520,7 @@ func (s *serviceImpl) doApiV1WorkflowGetPost(

if getErr == nil {
logevent.Log(iwfidl.IwfEvent{
EventType: iwfidl.COMPLETE_EVENT,
EventType: iwfidl.WORKFLOW_COMPLETE_EVENT,
WorkflowType: "",
WorkflowId: "",
WorkflowRunId: "",
Expand Down Expand Up @@ -570,13 +564,6 @@ func (s *serviceImpl) doApiV1WorkflowGetPost(
errMsgPtr = iwfidl.PtrString(errMsg)
}

logevent.Log(iwfidl.IwfEvent{
EventType: iwfidl.FAIL_EVENT,
WorkflowType: "",
WorkflowId: "",
WorkflowRunId: "",
})

return &iwfidl.WorkflowGetResponse{
WorkflowRunId: descResp.RunId,
WorkflowStatus: iwfidl.FAILED,
Expand All @@ -600,13 +587,6 @@ func (s *serviceImpl) doApiV1WorkflowGetPost(
}

if descResp.Status == iwfidl.FAILED {
logevent.Log(iwfidl.IwfEvent{
EventType: iwfidl.FAIL_EVENT,
WorkflowType: "",
WorkflowId: "",
WorkflowRunId: "",
})

errMsg = "unknown workflow failure from interpreter implementation"
s.logger.Error(errMsg, tag.WorkflowID(req.GetWorkflowId()), tag.WorkflowRunID(descResp.RunId))
}
Expand Down

0 comments on commit 6f2395e

Please sign in to comment.