IWF-254: Override WorkflowConfig field by field (#478)

indeedeng · Nov 13, 2024 · 6d69103 · 6d69103
1 parent 9973d43
commit 6d69103
Showing 1 changed file with 20 additions and 1 deletion.
diff --git a/service/api/service.go b/service/api/service.go
@@ -110,7 +110,8 @@ func (s *serviceImpl) ApiV1WorkflowStartPost(
 		initCustomSAs = startOptions.SearchAttributes
 		initCustomDAs = startOptions.DataAttributes
 		if startOptions.HasWorkflowConfigOverride() {
-			workflowConfig = startOptions.GetWorkflowConfigOverride()
+			configOverride := startOptions.GetWorkflowConfigOverride()
+			overrideWorkflowConfig(configOverride, &workflowConfig)
 		}
 
 		workflowAlreadyStartedOptions := startOptions.WorkflowAlreadyStartedOptions
@@ -192,6 +193,24 @@ func (s *serviceImpl) ApiV1WorkflowStartPost(
 	}, nil
 }
 
+func overrideWorkflowConfig(configOverride iwfidl.WorkflowConfig, workflowConfig *iwfidl.WorkflowConfig) {
+	if configOverride.ExecutingStateIdMode != nil {
+		workflowConfig.ExecutingStateIdMode = configOverride.ExecutingStateIdMode
+	}
+	if configOverride.ContinueAsNewThreshold != nil {
+		workflowConfig.ContinueAsNewThreshold = configOverride.ContinueAsNewThreshold
+	}
+	if configOverride.ContinueAsNewPageSizeInBytes != nil {
+		workflowConfig.ContinueAsNewPageSizeInBytes = configOverride.ContinueAsNewPageSizeInBytes
+	}
+	if configOverride.DisableSystemSearchAttribute != nil {
+		workflowConfig.DisableSystemSearchAttribute = configOverride.DisableSystemSearchAttribute
+	}
+	if configOverride.OptimizeActivity != nil {
+		workflowConfig.OptimizeActivity = configOverride.OptimizeActivity
+	}
+}
+
 func (s *serviceImpl) ApiV1WorkflowWaitForStateCompletion(
 	ctx context.Context, req iwfidl.WorkflowWaitForStateCompletionRequest,
 ) (wresp *iwfidl.WorkflowWaitForStateCompletionResponse, retError *errors.ErrorAndStatus) {