IWF-106: Fix typo IdReusePolicy of ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY (

#430)
indeedeng · Sep 25, 2024 · 6c47f1b · 6c47f1b
1 parent 0fea84a
commit 6c47f1b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/gen/iwfidl/api/openapi.yaml b/gen/iwfidl/api/openapi.yaml
@@ -702,7 +702,8 @@ components:
       type: string
     IDReusePolicy:
       enum:
-      - ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY
+      - ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY # Keeping typo enum for backwards compatibility
+      - ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY
       - ALLOW_IF_NO_RUNNING
       - DISALLOW_REUSE
       - ALLOW_TERMINATE_IF_RUNNING

diff --git a/gen/iwfidl/docs/IDReusePolicy.md b/gen/iwfidl/docs/IDReusePolicy.md
@@ -2,9 +2,11 @@
 
 ## Enum
 
-
+# Keeping typo enum for backwards compatibility
 * `ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY` (value: `"ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY"`)
 
+* `ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY` (value: `"ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY"`)
+
 * `ALLOW_IF_NO_RUNNING` (value: `"ALLOW_IF_NO_RUNNING"`)
 
 * `DISALLOW_REUSE` (value: `"DISALLOW_REUSE"`)

diff --git a/gen/iwfidl/model_id_reuse_policy.go b/gen/iwfidl/model_id_reuse_policy.go
diff --git a/service/common/compatibility/workflowStartOptions.go b/service/common/compatibility/workflowStartOptions.go
@@ -10,7 +10,8 @@ func GetWorkflowIdReusePolicy(options iwfidl.WorkflowStartOptions) *iwfidl.Workf
 		switch newType {
 		case iwfidl.ALLOW_IF_NO_RUNNING:
 			return iwfidl.ALLOW_DUPLICATE.Ptr()
-		case iwfidl.ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY:
+		case iwfidl.ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY, iwfidl.ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY:
+			// Keeping typo enum for backwards compatibility. Both old and corrected enums return the same result.
 			return iwfidl.ALLOW_DUPLICATE_FAILED_ONLY.Ptr()
 		case iwfidl.DISALLOW_REUSE:
 			return iwfidl.REJECT_DUPLICATE.Ptr()