Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update conanfile.py #1

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Update conanfile.py #1

merged 1 commit into from
Mar 11, 2019

Conversation

MagnusS
Copy link
Member

@MagnusS MagnusS commented Mar 11, 2019

  • Use scm section instead of git checkout
  • Use the same function names as in mana/conanfile.py
  • Automatic versioning based on commit id
  • Update metadata

Signed-off-by: Magnus Skjegstad magnus@skjegstad.com

@MagnusS
Update conanfile.py
14b4ea4 
- Use scm section instead of git checkout
- Normalise function names
- Automatic versioning based on commit id
- Update metadata

Signed-off-by: Magnus Skjegstad <magnus@skjegstad.com>
@MagnusS
Copy link
Member Author

MagnusS commented Mar 11, 2019

Tested locally with conan create ...

KristianJerpetjon
KristianJerpetjon approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@KristianJerpetjon KristianJerpetjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MagnusS MagnusS merged commit 578b2fe into includeos:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristianJerpetjon KristianJerpetjon KristianJerpetjon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MagnusS @KristianJerpetjon