Catch nil-deref when creating catalog entries #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelseymills
approved these changes
Jan 30, 2025
| @@ -43,6 +43,13 @@ func EntriesClientFromClient(cl *client.ClientWithResponses) EntriesClient { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if result == nil { | |||
| return nil, errors.New("unexpected nil response") | |||
There was a problem hiding this comment.
is there any metadata we can add here to help debug?
There was a problem hiding this comment.
the caller will log out the error alongside the external_id
I think from there on we'll need to ask the customer for the rest of the payload they've specified for that external ID
louisheath
added a commit
that referenced
this pull request
Jan 31, 2025
Related to #157 The nil dereference has been avoided however the catalog importer is still aborted mid-flow. Despite erroring, the catalog entry is successfully created, so the next retry succeeds. I can't reproduce this error locally, and from inspection our app code does not seem capable of returning an empty payload with a 201 status code. The customer reported seeing a 201 status code in their proxy, and our logs indicate that we responded with a 592 Byte response, which is larger than many other successful requests from their previous run. My only remaining theory is that the "Content-Type" header is missing - either it was never set or it was stripped mid-way. This would prevent us from marshalling the response in `client.gen.go`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer reported an error dereferencing
result.JSON201.CatalogEntryAll responses to this customer that morning were 201s, and
ParseCatalogV2CreateEntryResponseappears solidIt's near impossible to debug this without identifying the exact request, so we're adding nil-handling and will look again if it reappears