Update read_watersurfaces for version 2024 #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop hyla_code
- add wfd_type_alternative
- add wfd_type_alt_name
- include water_level_management
- add CFe in list water types
- use na_if for empty cells ("")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few preliminary checks in preprocessing>miscellaneous>watersurfaces.Rmd :
watersurfaces.zip
Here are the most important remarks/needed corrections for this new version 2024:
WVLCcode (“d”) in de Kleiputten van Heist (Palingpot): not corrected since it is the raw sourcewfd_type_alternative: added (and made optional since it is not present in all versions)hyla_code: made optional (since it is not present in all versions)Nice to try in the future (maybe we could add this as issue?)
What is the best (quickest/most readable) way to handle the fact that there are different structures/different fields/different errors to correct in the different versions?
Should we use
if thenstructures or use optional clauses (such asmatches,any_of,across+where, ...)?