Merge pull request #185 from inbo/ws_fix_geom_speedup

read_watersurfaces(): make fix_geom handling a bit more efficient
inbo · Aug 8, 2024 · 1f843ea · 1f843ea
2 parents 5291921 + 1ebd40d
commit 1f843ea
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/R/read_habitatdata.R b/R/read_habitatdata.R
@@ -674,12 +674,13 @@ read_watersurfaces <-
     }
 
     if (fix_geom) {
-      n_invalid <- sum(
-        !st_is_valid(watersurfaces) | is.na(st_is_valid(watersurfaces))
-      )
+      validities <- st_is_valid(watersurfaces)
+      n_invalid <- sum(!validities | is.na(validities))
       if (n_invalid > 0) {
         watersurfaces <- st_make_valid(watersurfaces)
         message("Fixed ", n_invalid, " invalid or corrupt geometries.")
+      } else {
+        message("No invalid or corrupt geometries found.")
       }
     }