Support for no_call and no_common_caveats #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
approved these changes
Jun 29, 2018
igaray
approved these changes
Jun 29, 2018
|
@adrianroe I'm merging the PR… please remember to update the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A discussed in inaka/elvis#484
I haven't update the docs as yet, but it all has tests and is dialyzer clean.
There is one issue at present, which is that the existing elvis_core code does not recognise calls to size as actually being calls to erlang:size so the test file, somewhat artificially has calls in it to erlang:size (whereas 99% of my code certainly does not usually use the erlang: prefix for this).
Perhaps one to talk through.