Rules for warning about seqbind #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2016 09:26
seqbind [1] is a parse transform for Erlang that allows the programmer to assign to "the same variable" multiples times, e.g., ```erlang X@ = 10, X@ = X@ + 1. ``` Although this transform can be useful at times, even its author recommends using it sparingly since it obscures the functional nature of Erlang, and can look quite ugly. This commit adds an elvis_style rule to detect when a module declares its intention to use seqbind. [1] https://github.com/spawngrid/seqbind
Give a warning to the user if he has declared his module to use the seqbind parse transform, yet no seq-bindings (i.e., VarName@) can be found in the module.
elbrujohalcon
requested changes
Oct 31, 2016
| @@ -25,6 +25,7 @@ | |||
| {test, [ | |||
| {deps, [ {katana_test, {git, "https://github.com/inaka/katana-test.git", {tag, "0.0.6"}}} | |||
| , {mixer, {git, "https://github.com/inaka/mixer.git", {tag, "0.1.5"}}} | |||
| , {seqbind, {git, "https://github.com/lpgauth/seqbind.git", {branch, "master"}}} | |||
There was a problem hiding this comment.
Don't use "master" branch, either choose a tag or use a commit SHA.
| lists:last(ktn_code:attr(text, Node)) =:= $@ | ||
| end, | ||
| Root), | ||
| case SeqBindings of |
There was a problem hiding this comment.
Instead of a case, you can do SeqBindings /= [] directly.
- Replace master branch for seqbind in rebar.config with explicit commit reference (seqbind doesn't have tags at the moment); - Replace explicit pattern matching for checking empty list with comparison with the empty list.
elbrujohalcon
approved these changes
Oct 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seqbind [1] is a parse transform for Erlang that allows the programmer to assign to "the same variable" multiples times, e.g.,
X@ = 10,
X@ = X@ + 1.
Although this transform can be useful at times, even its author recommends using it sparingly since it obscures the functional nature of Erlang, and can look quite ugly.
This PR adds:
Issue ref.: inaka/elvis#413