Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #407] Fix bug in max_function_length rule #64

Merged
merged 1 commit into from
Oct 19, 2016
Merged

[Fix #407] Fix bug in max_function_length rule #64

merged 1 commit into from
Oct 19, 2016

Conversation

harenson
Copy link
Member

No description provided.

elbrujohalcon
elbrujohalcon reviewed Oct 17, 2016
View reviewed changes
Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harenson maybe resubmit with the old rebar.lock ?

@harenson harenson force-pushed the harenson.407.max-function-length-check-fails-unexpectedly branch from cdbe49b to 8295332 Compare October 17, 2016 17:51
@harenson harenson closed this Oct 17, 2016
@harenson harenson reopened this Oct 17, 2016
@harenson harenson force-pushed the harenson.407.max-function-length-check-fails-unexpectedly branch from 8295332 to fe85c9b Compare October 19, 2016 19:54
@harenson harenson added the WIP label Oct 19, 2016
@harenson harenson changed the title [Fix #407] Fix bug in max_function_length rule [Fix #407] Fix bug in max_function_length rule (WIP) Oct 19, 2016
@harenson harenson force-pushed the harenson.407.max-function-length-check-fails-unexpectedly branch from fe85c9b to 7738e71 Compare October 19, 2016 21:02
@harenson harenson changed the title [Fix #407] Fix bug in max_function_length rule (WIP) [Fix #407] Fix bug in max_function_length rule Oct 19, 2016
@harenson harenson removed the WIP label Oct 19, 2016
@elbrujohalcon elbrujohalcon merged commit ad16894 into master Oct 19, 2016
@harenson harenson deleted the harenson.407.max-function-length-check-fails-unexpectedly branch October 19, 2016 21:06
@harenson harenson mentioned this pull request Oct 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elbrujohalcon elbrujohalcon elbrujohalcon left review comments

Assignees

@elbrujohalcon elbrujohalcon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harenson @elbrujohalcon