Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow errorless consumption by rebar3_lint #332

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

This will be required once we want to add more context to errors in the plugin. I'll prepare a pull request for that and only propose it for acceptance once this is merged, tagged and Hex-published, at least.

This will be required once we want to add more context
to errors in the plugin
@paulo-ferraz-oliveira
Copy link
Collaborator Author

For context, the change comes from

-spec do_parallel_rock(elvis_config:config()) ->
                          ok |
                          {fail, [{throw, term()} | elvis_result:file() | elvis_result:rule()]}.

being used as

    Results = lists:map(fun do_parallel_rock/1, NewConfig),
    lists:foldl(fun combine_results/2, ok, Results).

in rock/1, the updated function.

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 59861d4 into main Jan 18, 2024
14 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/spec branch January 18, 2024 14:27
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Going to release 3.2.1 on GitHub and Hex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants