Prevent sub-folder files from being analyzed twice

[paulo-ferraz-oliveira]

This is what is happening to me...
I have an elvis.config file such as

[{elvis, [
    {config, [
        #{ dirs => ["src",
                    "src/sub"],
           filter => "*.erl",
           ruleset => erl_files
    ]},
    {verbose, true}
]}].

When analyzing file file.erl inside folder src/sub it gets analyzed twice, since elvis_core's internals match it with both src/ and src/sub/.
The "solution" found was to un-duplicate these occurrences.

[elbrujohalcon]

Does this fix inaka/elvis#508?

[elbrujohalcon]

Related: 1d80b28#r36143723

[paulo-ferraz-oliveira]

Does this fix inaka/elvis#508?

Let me try to check that tonight. If it doesn't I might want to tackle that also.

[paulo-ferraz-oliveira]

Regarding dirs:

• ["src/**"]: same result (i.e. not fixed),
• ["src", "src/**"]: fixed,
• ["src", "src/*", "src/*/*"]: fixed.

[paulo-ferraz-oliveira]

I'm looking into why the issue occurs with ["src/**], but I need to understand initial requirements:

1. is declaring ["src"] supposed to be recursive?
2. is declaring ["src/**"] supposed to be recursive?

I feel there's a simpler approach to the problem (e.g. filesystem folder tree traversal...).

[paulo-ferraz-oliveira]

I'm looking into why the issue occurs with ["src/**], but I need to understand initial requirements:

1. is declaring ["src"] supposed to be recursive?
2. is declaring ["src/**"] supposed to be recursive?

I feel there's a simpler approach to the problem (e.g. filesystem folder tree traversal...).

I think I found my answer here: https://erlang.org/doc/man/filelib.html#wildcard-1.

[paulo-ferraz-oliveira]

This improves the analysis scope. Specifically, it deals with all the issues in inaka/elvis#508.

[elbrujohalcon]

Thank you, @paulo-ferraz-oliveira !!!

[paulo-ferraz-oliveira]

Thank you, @paulo-ferraz-oliveira !!!

Oh, this is nice 👍