Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of rebar_raw_resource in rebar3 -oriented projects #122

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Allow use of rebar_raw_resource in rebar3 -oriented projects #122

merged 2 commits into from
Aug 7, 2020

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

I have this entry in rebar.config's deps:

{dep, {raw, {git, "https://github.com/dep.git", {branch, "develop"}}}}

While analyzing rebar.config, elvis (via elvis_core) exits with:

# rebar.config [FAIL]
Error: 'badarg' while applying rule 'protocol_for_deps_rebar'.
===> Linting failed

That entry respects the format of rebar3 plugin rebar_raw_resource.

@elbrujohalcon elbrujohalcon merged commit c4b4442 into inaka:master Aug 7, 2020
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Many thanks.

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/protocol_for_deps_rebar_ignore branch August 7, 2020 19:53
@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elbrujohalcon elbrujohalcon elbrujohalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulo-ferraz-oliveira @elbrujohalcon