Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule: No specs in header files #268

Closed
elbrujohalcon opened this issue Feb 27, 2023 · 0 comments
Closed

New Rule: No specs in header files #268

elbrujohalcon opened this issue Feb 27, 2023 · 0 comments
Assignees
@elbrujohalcon
Labels
rule
Milestone
3.0.0

Comments

@elbrujohalcon
Copy link
Member

No specs in header files

Brief Description

Just like #162 but for specs.

Should be on by default?

YES

Reasoning

Same as #162.

Refactoring Proposal

Move the specs to where they belong.

Examples

%% bad.hrl
-spec a(function) -> _.

-define(A_MACRO, here).
%% good.hrl
-define(A_MACRO, here).
@elbrujohalcon elbrujohalcon added this to the 2.1.0 milestone Feb 27, 2023
@elbrujohalcon elbrujohalcon mentioned this issue Feb 27, 2023
Merged
@elbrujohalcon elbrujohalcon self-assigned this Feb 27, 2023
elbrujohalcon added a commit that referenced this issue Feb 27, 2023
@elbrujohalcon
Merge pull request #271 from inaka/brujo.268.no_specs
cb204f6 
Fix #268: New Rule: No Specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elbrujohalcon elbrujohalcon

Labels
rule
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@elbrujohalcon