Added the events system #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should add tests for this new functionality |
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| { deps | |||
| , [ {eper, "~> 0.94"} | |||
| , {epocxy, ".*", {git, "https://github.com/inaka/epocxy.git", {ref, "2b6a7c4"}}} | |||
| , {epocxy, ".*", {git, "https://github.com/HernanRivasAcosta/epocxy.git", {ref, "8778fa1"}}} | |||
There was a problem hiding this comment.
Why yours and not @duomark's version?
There was a problem hiding this comment.
This comma: https://github.com/duomark/epocxy/pull/65/files
I am going to wait for him to merge that PR.
d0875ca to
0a615c0
Compare
| catch erlang:spawn(M, F, A), | ||
| ok; | ||
| execute_hook([H | T], A) -> | ||
| ok = execute_hook(H, A), |
There was a problem hiding this comment.
This lines are not covered by tests. Most likely, considering how hooks are defined, they're not even needed.
0a615c0 to
23852c6
Compare
23852c6 to
72424a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's also a version bump.