Invalid node on Henchmen test

relx.config

@@ -1,5 +1,5 @@
 {release,
-  {beam_olympics, "0.0.1"},
+  {beam_olympics, "1.0.0"},
   [ kernel
   , stdlib
   , beam_olympics

src/bo_server.erl

@@ -35,7 +35,7 @@ init(noargs) -> {ok, #{}}.
 -spec handle_call
   (stats, {pid(), term()}, state()) ->
     {reply, bo_players_repo:stats(), state()};
-  ({signup, bo_players:name()}, {pid(), term()}, state()) ->
+  ({signup, term()}, {pid(), term()}, state()) ->
     {reply, {ok, bo_task:task()} | {error, conflict}, state()};
   ({task, bo_players:name()}, {pid(), term()}, state()) ->
     {reply, {ok, bo_task:task()}
@@ -51,6 +51,8 @@ init(noargs) -> {ok, #{}}.
           | {error, ended | forbidden | notfound}, state()}.
 handle_call(stats, _From, State) ->
   {reply, bo_players_repo:stats(), State};
+handle_call({signup, Data}, _From, State) when not is_binary(Data) ->
+  {reply, {error, invalid}, State};
 handle_call({signup, PlayerName}, {From, _}, State) ->
   Node = node(From),
   try bo_players_repo:signup(PlayerName, Node) of

src/tasks/bo_henchmen.erl

@@ -78,7 +78,7 @@ kills_siblings(Fun) ->
 doesnt_kill_remotes(Fun) ->
   Harry = Fun(),
   [Node | _] = nodes(),
-  Victim = spawn(Node, fun() -> receive x -> ok end end),
+  Victim = spawn(Node, timer, sleep, [3000]),
   try
     true = is_process_alive(Harry),
     true = rpc:pinfo(Victim) /= undefined,

test/bo_player_SUITE.erl

@@ -3,12 +3,12 @@
 
 -export([all/0]).
 -export([init_per_suite/1, end_per_suite/1]).
--export([register_ok/1, wrong_node/1, duplicated_username/1]).
+-export([register_ok/1, wrong_node/1, duplicated_username/1, wrong_username/1]).
 
 -type config() :: proplists:proplist().
 
 -spec all() -> [atom()].
-all() -> [register_ok, duplicated_username, wrong_node].
+all() -> [register_ok, duplicated_username, wrong_node, wrong_username].
 
 -spec init_per_suite(config()) -> config().
 init_per_suite(Config) ->
@@ -80,13 +80,13 @@ duplicated_username(_Config) ->
   {ok, Client2} = bo_test_client:start(duplicated_username2),
 
   try
-    ct:comment("User ok is created in node1"),
+    ct:comment("User dup is created in node1"),
     {ok, _Task} = bo_test_client:signup(Client1, <<"dup">>),
 
-    ct:comment("User ok can't be created in node1"),
+    ct:comment("User dup can't be created in node1"),
     {error, conflict} = bo_test_client:signup(Client1, <<"dup">>),
 
-    ct:comment("User ok can't be created in node2"),
+    ct:comment("User dup can't be created in node2"),
     {error, conflict} = bo_test_client:signup(Client2, <<"dup">>),
 
     ok
@@ -96,3 +96,20 @@ duplicated_username(_Config) ->
   end,
 
   {comment, ""}.
+
+-spec wrong_username(config()) -> {comment, string()}.
+wrong_username(_Config) ->
+  {ok, Client1} = bo_test_client:start(duplicated_username1),
+  {ok, Client2} = bo_test_client:start(duplicated_username2),
+
+  try
+    ct:comment("User with invalid name can't be created"),
+    {error, invalid} = bo_test_client:signup(Client1, not_a_binary),
+
+    ok
+  after
+    ok = bo_test_client:stop(Client1),
+    ok = bo_test_client:stop(Client2)
+  end,
+
+  {comment, ""}.

test/bo_test_client.erl

@@ -5,7 +5,7 @@
 -export([gen_call/2]).
 
 -type task() :: bo_task:task().
--type player_name() :: binary().
+-type player_name() :: term().
 
 -spec start(atom()) -> {ok, node()}.
 start(NodeName) ->