Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command init to auto-generate template witness yaml file #347

Closed
wants to merge 4 commits into from

Conversation

ChaosInTheCRD
Copy link
Collaborator

a quick pr to allow the user to automatically generate a witness.yml file with empty values for the purpose of easing the process of creating them. This should also encourage the use of the witness.yml file.

I have also added some code to the docgen/docs.go file so that updates to the schema can be autotemplated in.

the init command name is of course subject to change depending on peoples thoughts on what the command name should be, as well as the decision to even have this functionality merged upstream.

Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
@colek42
Copy link
Member

colek42 commented Jan 6, 2024

This is related to the second point in this security issue. #268.

See this security advisory for in-toto: GHSA-wc64-c5rv-32pf

I think we could mitigate by forcing a -c flag for the config file location

@ChaosInTheCRD
Copy link
Collaborator Author

At the moment it does not seem clear as to how this PR fits in with the structure of the CLI. Therefore, I am going to close this draft PR, but I will create an issue that references the work with the desire to add functionality for auto-generating witness config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants