Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(fulcio): Fixes Witness #535 #402

Merged
merged 1 commit into from
Feb 17, 2025
Merged

bug(fulcio): Fixes Witness #535 #402

merged 1 commit into from
Feb 17, 2025

Conversation

jkjell
Copy link
Member

@jkjell jkjell commented Dec 16, 2024

What this PR does / why we need it

Description

Which issue(s) this PR fixes

Fixes in-toto/witness#535

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

@jkjell jkjell marked this pull request as draft December 16, 2024 18:39
@jkjell jkjell force-pushed the grpc_new_client_opts branch from 2a20793 to 52591f0 Compare December 16, 2024 20:24
@jkjell jkjell mentioned this pull request Dec 16, 2024
Closed
@jkjell jkjell force-pushed the grpc_new_client_opts branch from 52591f0 to 37dce52 Compare December 17, 2024 15:09
@jkjell jkjell force-pushed the grpc_new_client_opts branch 2 times, most recently from 41d66f9 to 8aae04e Compare February 16, 2025 17:45
@jkjell jkjell marked this pull request as ready for review February 16, 2025 17:45
@jkjell jkjell force-pushed the grpc_new_client_opts branch 3 times, most recently from 8b16741 to 5864721 Compare February 16, 2025 18:06
@jkjell
bug(fulcio): Fixes #535
9f3fb1e 
Signed-off-by: John Kjell <john@testifysec.com>
@jkjell jkjell force-pushed the grpc_new_client_opts branch from 5864721 to 9f3fb1e Compare February 16, 2025 18:15
@jkjell jkjell merged commit 46d5291 into main Feb 17, 2025
16 checks passed
@jkjell jkjell deleted the grpc_new_client_opts branch February 17, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairoaraujo kairoaraujo kairoaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: NO_PROXY does not seem to be respected
2 participants
@jkjell @kairoaraujo