EmptyStatement
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
reviewed
Mar 16, 2023
sandersn
reviewed
Apr 19, 2023
|
@sandersn, do you think this solution/implementation fits the |
sandersn
approved these changes
Apr 27, 2023
src/emit.ts
Outdated
| @@ -1,7 +1,7 @@ | |||
| import { Statement, Node, Expression } from './types'; | |||
|
|
|||
| export function emit(statements: Statement[]) { | |||
| return statements.map(emitStatement).join(';\n'); | |||
| return statements.filter(Boolean).map(emitStatement).join(';\n'); | |||
There was a problem hiding this comment.
I would personally leave the empty statements in the output, since the output should be as close as possible to the input, but with types removed.
There was a problem hiding this comment.
That makes sense, just removed the filter imteekay/mini-typescript@6182029
src/check.ts
Outdated
| @@ -13,6 +13,7 @@ import { resolve } from './bind'; | |||
| const stringType: Type = { id: 'string' }; | |||
| const numberType: Type = { id: 'number' }; | |||
| const errorType: Type = { id: 'error' }; | |||
| const emptyType: Type = { id: 'empty' }; | |||
There was a problem hiding this comment.
For bonus points, see what the spec says an empty statement returns and name the type after that.
There was a problem hiding this comment.
Looking at the spec, it says it returns empty. Just renamed from emptyType to empty imteekay/mini-typescript@6da8ef0 Lmk if this is what you meant for the refactoring.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the empty statement token
EmptyStatementsandersn/mini-typescript#14