Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow var to have multiple declarations #2

Merged
merged 9 commits into from
Aug 1, 2023
Merged

Allow var to have multiple declarations #2

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c657e1
Add example
imteekay Jul 22, 2023
3409216
Add baselines
imteekay Jul 22, 2023
fbb1aad
`valueDeclaration` should store the first variable declaration
imteekay Jul 22, 2023
c3568b1
Handle multiple declarations with different types
imteekay Jul 22, 2023
435a298
Refactor to handle subsequent var types errors
imteekay Jul 22, 2023
650af4e
Handling when the second variable declaration has a mismatch between …
imteekay Jul 23, 2023
f8c7d51
Merge branch 'master' into var-with-multiple-declarations
imteekay Aug 1, 2023
afe6c0f
Check exercise
imteekay Aug 1, 2023
f371f0a
Update readme
imteekay Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions baselines/reference/multipleDeclarationsWithDifferentTypes.errors.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[
{
"pos": 122,
"message": "Subsequent variable declarations must have the same type. Variable 's3' must be of type 'number', but here has type 'string'."
},
{
"pos": 168,
"message": "Subsequent variable declarations must have the same type. Variable 's4' must be of type 'string', but here has type 'number'."
},
{
"pos": 222,
"message": "Cannot assign initialiser of type 'number' to variable with declared type 'string'."
}
]
1 change: 1 addition & 0 deletions baselines/reference/multipleDeclarationsWithDifferentTypes.js.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"var s = 'test';\nvar s1 = 'test';\nvar s2 = 'test';\nvar s2 = 'test';\nvar s3 = 2;\nvar s3 = 'test';\nvar s4 = 'test';\nvar s4 = 2;\nvar s4 = 'test';\nvar s5 = 'test';\nvar s5 = 2;\n"
314 changes: 314 additions & 0 deletions baselines/reference/multipleDeclarationsWithDifferentTypes.tree.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,314 @@
{
"locals": {
"s": [
{
"kind": "VariableDeclaration",
"pos": 15
}
],
"s1": [
{
"kind": "VariableDeclaration",
"pos": 41
}
],
"s2": [
{
"kind": "VariableDeclaration",
"pos": 59
},
{
"kind": "VariableDeclaration",
"pos": 84
}
],
"s3": [
{
"kind": "VariableDeclaration",
"pos": 105
},
{
"kind": "VariableDeclaration",
"pos": 122
}
],
"s4": [
{
"kind": "VariableDeclaration",
"pos": 148
},
{
"kind": "VariableDeclaration",
"pos": 168
},
{
"kind": "VariableDeclaration",
"pos": 185
}
],
"s5": [
{
"kind": "VariableDeclaration",
"pos": 203
},
{
"kind": "VariableDeclaration",
"pos": 223
}
]
},
"statements": [
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s"
},
"init": {
"kind": "StringLiteral",
"value": "test",
"isSingleQuote": true
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s1"
},
"typename": {
"kind": "Identifier",
"text": "string"
},
"init": {
"kind": "StringLiteral",
"value": "test",
"isSingleQuote": true
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s2"
},
"init": {
"kind": "StringLiteral",
"value": "test",
"isSingleQuote": true
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s2"
},
"typename": {
"kind": "Identifier",
"text": "string"
},
"init": {
"kind": "StringLiteral",
"value": "test",
"isSingleQuote": true
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s3"
},
"typename": {
"kind": "Identifier",
"text": "number"
},
"init": {
"kind": "NumericLiteral",
"value": 2
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s3"
},
"init": {
"kind": "StringLiteral",
"value": "test",
"isSingleQuote": true
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s4"
},
"typename": {
"kind": "Identifier",
"text": "string"
},
"init": {
"kind": "StringLiteral",
"value": "test",
"isSingleQuote": true
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s4"
},
"typename": {
"kind": "Identifier",
"text": "number"
},
"init": {
"kind": "NumericLiteral",
"value": 2
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s4"
},
"init": {
"kind": "StringLiteral",
"value": "test",
"isSingleQuote": true
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s5"
},
"init": {
"kind": "StringLiteral",
"value": "test",
"isSingleQuote": true
}
}
},
"flags": 0
}
},
{
"kind": "VariableStatement",
"declarationList": {
"kind": "VariableDeclarationList",
"declarations": {
"0": {
"kind": "VariableDeclaration",
"name": {
"kind": "Identifier",
"text": "s5"
},
"typename": {
"kind": "Identifier",
"text": "string"
},
"init": {
"kind": "NumericLiteral",
"value": 2
}
}
},
"flags": 0
}
}
]
}
1 change: 1 addition & 0 deletions baselines/reference/varWithMultipleDeclarations.errors.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
1 change: 1 addition & 0 deletions baselines/reference/varWithMultipleDeclarations.js.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"var var1 = 'test';\nvar var1 = 'var';\nvar var1 = 'no type annotation needed';\n"
Loading