Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation instruction with brew #75

Merged
merged 2 commits into from
Jan 5, 2020
Merged

Conversation

smorimoto
Copy link
Contributor

Closes #9

It has been made available for brew by Homebrew/homebrew-core#48504.

@smorimoto
Copy link
Contributor Author

Also, the official name of the current macOS is macOS, not MacOS, so I have fixed it.

@smorimoto
Copy link
Contributor Author

Note for users: When running on macOS, it should be run with sudo.

@@ -90,6 +90,7 @@ pub fn get_input(
Some(interface) => vec![interface],
None => {
failure::bail!("Cannot find interface {}", name);
// the homebrew formula relies on this wording, please be careful when changing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comment 🙂

@imsnif
Copy link
Owner

imsnif commented Jan 5, 2020

Hah! Thanks for the name correction :)

I added a comment in the code so that no one will accidentally break the formula test.

Question: in order to build bandwhich, we need a rust version of at least 1.39.0. Should this be part of the formula in any way, or is that out of scope?

@smorimoto
Copy link
Contributor Author

smorimoto commented Jan 5, 2020

@imsnif
Copy link
Owner

imsnif commented Jan 5, 2020

Awesome. Thanks for pointing this out!

And thanks very much for doing this! :) Let me know if you need anything from me regarding future releases and such.

@imsnif imsnif merged commit ba82d37 into imsnif:master Jan 5, 2020
@smorimoto
Copy link
Contributor Author

I'm watching the release so I can create a PR for the version bump. but I will share this document just in case I can't do that.
https://github.com/Homebrew/brew/blob/master/docs/How-To-Open-a-Homebrew-Pull-Request.md#submit-a-new-version-of-an-existing-formula

@smorimoto smorimoto deleted the patch-1 branch January 5, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to Homebrew
2 participants