-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation instruction with brew #75
Conversation
Also, the official name of the current macOS is macOS, not MacOS, so I have fixed it. |
Note for users: When running on macOS, it should be run with sudo. |
@@ -90,6 +90,7 @@ pub fn get_input( | |||
Some(interface) => vec![interface], | |||
None => { | |||
failure::bail!("Cannot find interface {}", name); | |||
// the homebrew formula relies on this wording, please be careful when changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice comment 🙂
Hah! Thanks for the name correction :) I added a comment in the code so that no one will accidentally break the formula test. Question: in order to build bandwhich, we need a rust version of at least 1.39.0. Should this be part of the formula in any way, or is that out of scope? |
The formula uses the latest Rust. (Currently it's |
Awesome. Thanks for pointing this out! And thanks very much for doing this! :) Let me know if you need anything from me regarding future releases and such. |
I'm watching the release so I can create a PR for the version bump. but I will share this document just in case I can't do that. |
Closes #9
It has been made available for brew by Homebrew/homebrew-core#48504.