feat: add support for PresentationDefinition by value
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-mader
reviewed
Jun 6, 2024
daniel-mader
approved these changes
Jun 11, 2024
berkes
added a commit
to educredentials/ssi-agent
that referenced
this pull request
Jun 26, 2024
* upstream/dev: (23 commits) feat: add `issuance-config.yml` file, deprecate `/v0/configurations/credential_configurations` endpoint (impierce#91) chore: revert api version to `v0` (impierce#88) chore: improve Dockerfile and docker functionality (impierce#89) feat: add support for multiple credential formats (impierce#85) fix: move dockerignore because it won't be respected otherwise (impierce#84) feat: add `/v1/configurations/credential_configurations` endpoint (impierce#83) feat: add Metadata `config.yml` file (impierce#82) chore: add tracing to `agent_event_publisher_http` (impierce#80) chore: use `domain-linkage` (no `-fetch`) feature in `identity_credential` (impierce#79) feat: create and serve `Domain Linkage Credential` (impierce#77) docs: list available events (impierce#78) feat: produce and serve `did:web` DID documents (impierce#31) feat: add support for `PresentationDefinition` by value (impierce#72) feat: use polling strategy for JIT credentials (impierce#71) ci: switch from manual triggers to pushes to `dev` (impierce#76) ci: use dedicated `arm64` runner (impierce#74) feat: add `offer_id` to all `OfferEvent` events (impierce#69) feat: enable `CorsLayer` (permissive) based on env variable (impierce#66) fix: add image `tags` in `merge` job (impierce#63) fix: add `state` to `AuthorizationResponseVerified` events (impierce#60) ...
1 task
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change adds support for
PresentationDefinitionby value. This means when producing an OID4VP Authorization Request one can supply the necessaryPresentationDefinitionby value instead of supplying thepresentation_definition_id.Links to any relevant issues
Fixes #65
How the change has been tested
Added the following test cases to
test_authorization_requests_endpoint:Split the existing
POST authorization_requestrequest in the Postman collection into:siopv2_authorization_requestsoid4vp_authorization_requests_with_presentation_definitionoid4vp_authorization_requests_with_presentation_definition_idDefinition of Done checklist
Add an
xto the boxes that are relevant to your changes.