-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add AGENT_ISSUANCE_CREDENTIAL_LOGO_URL
and test
feature flag
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
changed the title
Feat/image uri
feat: add Dec 20, 2023
AGENT_ISSUANCE_CREDENTIAL_LOGO_URL
and test
feature flag
nanderstabel
force-pushed
the
feat/image-uri
branch
from
December 20, 2023 15:28
3a44058
to
e0a7b58
Compare
agent_api_rest/src/credential_issuer/well_known/openid_credential_issuer.rs
Outdated
Show resolved
Hide resolved
daniel-mader
approved these changes
Dec 21, 2023
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds the option to add a logo uri to credentials by utilizing a new
AGENT_ISSUANCE_CREDENTIAL_LOGO_URL
environment variable (and an optional credential name by utilizingAGENT_ISSUANCE_CREDENTIAL_NAME
. For example:Links to any relevant issues
n/a
How the change has been tested
The
config!
macro had to be slightly altered in order for it to be useful in unit tests outside of theagent_shared
crate. This is solved by introducing atest
feature flag for that crate that allows outside crates (for testing purposes) to read environment variables fromagent_shared/tests/.env.test
instead of the global.env
file.This allowed for adding a value for the display field in the
test_oauth_authorization_server_endpoint
test:Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.