Support llvm 17.0.0 #1041
Merged
Support llvm 17.0.0 #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2930646 to
e64a33d
Compare
Also adds extremely limited support for ARMs scalable vector extension types such that Apple Silicon macs can run unit tests..
e64a33d to
39f8ceb
Compare
kkysen
reviewed
Nov 4, 2023
Comment on lines
+100
to
+106
| #else | ||
| #include <optional> | ||
| std::optional<APSInt> getIntegerConstantExpr(const Expr &E, | ||
| const ASTContext &Ctx) { | ||
| return E.getIntegerConstantExpr(Ctx); | ||
| } | ||
| #endif // CLANG_VERSION_MAJOR |
There was a problem hiding this comment.
Does std::optional exist before this? Maybe it's better to keep this function signature always the same and do any conversions inside the function. That way we won't run into any issues at call sites where we use some API that's on std::optional but not llvm::Optional.
There was a problem hiding this comment.
My understanding is that LLVM's Optional type got deprecated with the switch to C++ 17 (source). Therefore, the intent is to not use Optional if we're on LLVM 17 or later; that's why the function signature is intentionally changing.
There was a problem hiding this comment.
Ah, did LLVM just change to using C++ 17 for itself?
kkysen
approved these changes
Nov 4, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
llvm/clang17.0.0, as well as just enough support for ARM SVE types so that things don't crash on Apple Silicon.