fix(web): slideshow ascending order when video has ended #8024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
b96a07d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a8da99fd.immich.pages.dev |
| Branch Preview URL: | https://fix-slideshow-video.immich.pages.dev |
|
|
||
| const handleCanPlay = async (event: Event) => { | ||
| try { | ||
| const video = event.currentTarget as HTMLVideoElement; | ||
| video.muted = true; | ||
| await video.play(); | ||
| video.muted = false; | ||
| dispatch('onVideoStarted'); | ||
| if (onVideoStart) { |
There was a problem hiding this comment.
just curious, does onVideoStart ?? onVideoStart() work?
There was a problem hiding this comment.
You would want to do onVideoStart && onVideoStart() and that should work, yea
There was a problem hiding this comment.
Really it should just be onVideoStart?.()
2f5d2ae to
1feb877
Compare
jrasm91
reviewed
Mar 18, 2024
Comment on lines
450
to
452
| $slideshowNavigation === SlideshowNavigation.AscendingOrder | ||
| ? await navigateAsset('previous') | ||
| : await navigateAsset('next'); |
There was a problem hiding this comment.
Man, I really dislike this. We're adding more duplicate code everywhere and the asset-viewer is even more coupled to the slideshow functionality than it was before. The component should only be in charge of rendering an asset, not managing all this unrelated state.
There was a problem hiding this comment.
I moved everything to navigateAsset
4436bd5 to
b96a07d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When video has ended, the slideshow order is not respected. This PR fix it.