refactor: get map markers database query #15899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
approved these changes
Feb 4, 2025
mertalev
reviewed
Feb 4, 2025
Comment on lines
99
to
100
| .where('exif.latitude', 'is not', null) | ||
| .where('exif.longitude', 'is not', null) |
There was a problem hiding this comment.
The filter ends up being duplicated since it's in the join condition as well.
Also just FYI that where conditions and join conditions work the same for inner joins. It pre-filters either way. It's different for left joins - join conditions are better for left joins (e.g. it's better to join on a = 1 than to filter by x.a = 1 or x is null).
There was a problem hiding this comment.
Ah, woops. I meant to delete the where clauses.
alextran1502
added a commit
that referenced
this pull request
Feb 4, 2025
alextran1502
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push the exifInfo lat/lon is not null filter to the inner join. Also, only select the columns we need from exifInfo.