Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): save color when creating tag #15106

Merged

Conversation

scottdesilva
Copy link
Contributor

tag color wasn't being passed on tag creation, so I'm just correcting that here.

Let me know if I'm missing anything, this is my first PR for this project :)

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could you also add a simple unit test for this?

@jrasm91 jrasm91 merged commit c78e9d6 into immich-app:main Jan 6, 2025
34 of 35 checks passed
@scottdesilva
Copy link
Contributor Author

Since this has been closed, I've opened a new PR to address your feedback @danieldietzler

ovidijusr pushed a commit to ovidijusr/immich that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When calling the createTag api, specifying a color in the request does not actually set the color.
3 participants