feat(cli): watch paths for auto uploading daemon #14923
Open
+409
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78824da to
32ba427
Compare
jrasm91
reviewed
Dec 28, 2024
c267202 to
3e74c98
Compare
mertalev
reviewed
Jan 14, 2025
| batchSize, | ||
| debounceTimeMs, | ||
| onBatch: async (paths: string[]) => { | ||
| const uniquePaths = [...new Set(paths)]; |
There was a problem hiding this comment.
When would these ever not be unique?
| return; | ||
| } | ||
| const ext = '.' + path.split('.').pop()?.toLowerCase(); | ||
| if (!extensions.has(ext ?? '')) { |
There was a problem hiding this comment.
!ext || !extensions.has(ext)
| if (!extensions.has(ext ?? '')) { | ||
| return; | ||
| } | ||
| console.log(`Change detected: ${path}`); |
There was a problem hiding this comment.
How does this interact with the progress bar?
| @@ -69,6 +69,13 @@ program | |||
| .default(4), | |||
| ) | |||
| .addOption(new Option('--delete', 'Delete local assets after upload').env('IMMICH_DELETE_ASSETS')) | |||
| .addOption(new Option('--no-progress', 'Hide progress bars').env('IMMICH_PROGRESS_BAR').default(true)) | |||
There was a problem hiding this comment.
Why is this hiding progress by default? The option and the env name are confusing me.
Comment on lines
+231
to
+233
| this.onBatch([...this.items]); | ||
|
|
||
| this.items.length = 0; |
There was a problem hiding this comment.
Pass this.items without cloning and then set it to a new empty array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--watchflag to continue watching for changes after initial upload.immich upload ./assets/ --watch--watch, as it batch uploads all current items in one go.--no-progressflag to hide progress bars to make logs cleaner when running as a daemon--watchflag