feat: support geesefs by allowing to skip utimes

[denysvitali]

This fixes #14005 by adding an environment variable that allows to skip the utimes call on filesystems that do not support it.

Thanks to this fix, it's possible to use an S3 storage in Immich via the geesefs FUSE filesystem.

This could indirectly fix #4445 too (or at least provide a workaround).

[github-actions]

Label error. Requires exactly 1 of: changelog:.*. Found: documentation, 🗄️server

[jrasm91]

I think I'd rather see utime errors be ignored

[zackpollard]

Personally, and as was mentioned in the issue when it was opened, we don't want to support non-POSIX filesystems. This is a rabbit hole that we don't really want to get into, I can see it ending with us adding these kind of patches for a bunch of things filesystems should be providing.

[denysvitali]

Personally, and as was mentioned in the issue when it was opened, we don't want to support non-POSIX filesystems. This is a rabbit hole that we don't really want to get into, I can see it ending with us adding these kind of patches for a bunch of things filesystems should be providing.

Supporting some FUSE filesystems (especially S3) might be a quick win. Personally I think this one line change won't hurt and might help more users in the same situation.

[zackpollard]

Personally, and as was mentioned in the issue when it was opened, we don't want to support non-POSIX filesystems. This is a rabbit hole that we don't really want to get into, I can see it ending with us adding these kind of patches for a bunch of things filesystems should be providing.

Supporting some FUSE filesystems (especially S3) might be a quick win. Personally I think this one line change won't hurt and might help more users in the same situation.

We have plenty of people using S3 without needing to make this concession, I am not familiar with those setups specifically, however I imagine their mount tool just ignores utime updates instead of throwing errors.

[bo0tzz]

Personally I think this one line change won't hurt

Even if it doesn't, it opens the door to more special cases to support misbehaving filesystems and that's not a road we want to go down.

[denysvitali]

FYI - I fixed this on my side by patching the fs library:

const fs = require('fs');
// Patch the async version
fs.utimes = function(path, atime, mtime, callback) {
    // Just call callback successfully without doing the operation
    if (callback) process.nextTick(callback);
    return Promise.resolve();
};

// Patch the sync version
fs.utimesSync = function(path, atime, mtime) {
    // Do nothing and return
    return;
};

// Patch the promises version if it exists
if (fs.promises) {
    fs.promises.utimes = fs.utimes;
}
console.log('Patched fs.utimes to be no-op');

Then NODE_OPTIONS can be set to --require /patch/fs-patch.js.

This way, we don't make modifications to immich's source code but still get geesefs support.