Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person is created but are not shown in the People list. #13551

Open
1 of 3 tasks
hitech95 opened this issue Oct 17, 2024 · 1 comment
Open
1 of 3 tasks

Person is created but are not shown in the People list. #13551

hitech95 opened this issue Oct 17, 2024 · 1 comment
Assignees

Comments

@hitech95
Copy link
Contributor

hitech95 commented Oct 17, 2024

The bug

Issue #13245 is part of a deeper problem on the API for people.
While PR #13288 try to mitigate it it open a door to other issues.

When a face detection meet threshold person is created;
but people list doesnt show the newly created person, while
the counter is updated.

The photo that triggered the person creation has the person is
correctly assigned to the person but the other "faces" that contributed
to the threshold are not added.

The same happends when a photo has a face and you manually create
a person for such picture. But is seems that by assigning a name to the
person it trigger some logic and the person is shown.

This also means that I cannot assign the new created person to other
image via the sidecard as the API still return only the person with at
least facialRecognition.minFaces.

I think that the underlying issues are 2:

  • A person need to match the ML face threshold to be shown.
  • When person is made (via face detection or manually from the photo
    sidecard) the job to match the faces is not queued.

This create the mismatch between the counter and the list.
As the list require the threshold to be matched to show an element.

I'm seeing the following solutions:

  1. Trust that a person is generated only if the threshold is meet or it has been done my an user.
    If a person has been generated and has at lease one picture then is always show.
    AFIK the person is always shown if has a name even if it doesnt meet the facialRecognition.minFaces threshold but
    it could be a side effect of assigning a name after the personc reation that trigger some other background job)
  2. Queue a face match scan on the full library each time a new person has been created.
    This automatically re-scan the library to connect the faces to the right person.
    This is resource intensive for nothing
  3. Attach the feces (matches) used to calculate the threshold to such person.
  4. The sidecard to attach a person to an unmatched face also includes the persons that haven't met the threshold.

I think that the best scenario would be to implement 1,2,4.

The OS that Immich Server is running on

Debian 12

Version of Immich Server

1.118.2

Version of Immich Mobile App

ND

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

NA

Your .env content

NA

Reproduction steps

  1. set facialRecognition.minFaces to 3 (default)
  2. upload 3 picture of the same person
  3. the last uploaded picture trigger the person creation
  4. the other 2 pictures still have the unmatched person

Relevant log output

No response

Additional information

No response

@hitech95 hitech95 changed the title Person are created but are not shown in the People list. Person is created but are not shown in the People list. Oct 17, 2024
@mlinko6
Copy link

mlinko6 commented Nov 24, 2024

I have a similar Issue, I create new people but are not shown in the People - and can't be found either... There is also a thing that if I "hide" people not all faces that are still not hidenn are shown... I can scroll in the hidden section to hide some more people and save the changes, but when I open the people and hidden faces again there are the same faces still unhidden allthough I've just hidden them...

These are the people that are shown all the time allthough I've hidden them many times. I've also restarted all the containers but it didn't change.

Screenshot 2024-11-24 144603

Should I open another Issue?

P.S.: If I hide more people the "people" counter on unhidden faces doesn't change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants