Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People count doesn't respect minimum recognized faces #13245

Open
1 of 3 tasks
waclaw66 opened this issue Oct 7, 2024 · 3 comments
Open
1 of 3 tasks

People count doesn't respect minimum recognized faces #13245

waclaw66 opened this issue Oct 7, 2024 · 3 comments

Comments

@waclaw66
Copy link
Contributor

waclaw66 commented Oct 7, 2024

The bug

Faces are shown according "Minimum recognized faces" settings, but People count is not affected, it still shows the same count.
If minimum is set to 1, faces and count is shown as 161,
if minimum is set to 2, 138 faces is shown, count is still 161.

obrazek
obrazek

The OS that Immich Server is running on

Fedora 40

Version of Immich Server

v1.117.0

Version of Immich Mobile App

not relevant

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

not relevant

Your .env content

not relevant

Reproduction steps

Relevant log output

No response

Additional information

No response

@jedi04
Copy link
Contributor

jedi04 commented Oct 7, 2024

I tried this and I was also getting the same issue. But when you re run Facial Recognition job for all the assets. It solves this issue.

The query used to fetch count does not consider this option[Minimum Recognized Faces]

.having('COUNT(face.assetId) != 0')

While the query which is used to fetch faces uses this option and that's why count does not match the faces

.having("person.name != '' OR COUNT(face.assetId) >= :faces", { faces: options?.minimumFaceCount || 1 })

@jedi04
Copy link
Contributor

jedi04 commented Oct 7, 2024

We can use the same filter while fetching the count also. Can i take up this issue?

@C-Otto
Copy link
Contributor

C-Otto commented Oct 8, 2024

@jedi04 sure, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants