IE11 breaks if window.location is passed to produce

[kdelmonte]

🐛 Bug Report

If you pass window.location as the draft to produce, IE11 throws an error. The error is essentially the same one described in this core-js issue.

In short, IE11's native Object.getOwnPropertyDescriptor can't work with environment exotic objects which is the cause for this bug.

You can easily reproduce the issue by pasting this in your IE11 Dev Tools and hitting enter.

Object.getOwnPropertyDescriptor(window.location, 'host')

Link to repro

https://github.com/kdelmonte/immer-ie11-window-location-bug

To Reproduce

• Clone the repo
• Install the serve package
• Run the following command yarn build && serve -s build
• Navigate to http://localhost:5000 using IE 11 and see how the app does not load
• Navigate to http://localhost:5000 using Chrome/FF and see how the app loads fine

To verify that the app loads fine in IE 11 without this bug:

• Comment out the lines 9-11 in the src/index.js file
• Run yarn build && serve -s build once again

Observed behavior

If you pass window.location as the draft to produce, IE11 throws an error.

Expected behavior

produce should be able to successfully create a draft from any object in any of the supported browsers.

Environment

• Latest version of Windows 10
• Latest version of IE11
• Immer 5.2.0

• Immer version:
• Occurs with setUseProxies(true)
• Occurs with setUseProxies(false) (ES5 only)

[illuminist]

Immutability with normal JavaScript objects, arrays, Sets and Maps.

I might be wrong, but immer isn't intended to be used with exotic object.

[kdelmonte]

Immutability with normal JavaScript objects, arrays, Sets and Maps.

I might be wrong, but immer isn't intended to be used with exotic object.

@illuminist I think the docs use the phrase "normal JavaScript objects, arrays, Sets and Maps" to highlight the fact that immer does not have its own types such as Immutable.js. I don't think the phrase is there to explicitly exclude exotics.

In any case, if this is true and the immer community has no interest in supporting exotics, the docs should be updated to reflect this. Let's see what the maintainers have to say.

[mweststrate]

Correct. Feel free to PR an `Exotic objects are not supported` behind that or in the pitfalls section :)

…

On Wed, Jan 29, 2020 at 1:01 PM Kelvin Del Monte ***@***.***> wrote: Immutability with normal JavaScript objects, arrays, Sets and Maps. I might be wrong, but immer isn't intended to be used with exotic object. @illuminist <https://github.com/illuminist> I think the docs use the phrase "normal JavaScript objects, arrays, Sets and Maps" to highlight the fact that immer does not have its own types such as Immutable.js. I don't think the phrase is there to explicitly exclude exotics. In any case, if this is true and the immer community has no interest in supporting exotics, the docs should be updated to reflect this. Let's see what the maintainers have to say. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#504?email_source=notifications&email_token=AAN4NBAQ4F5QMJ2Y5AHJMHTRAF43HA5CNFSM4KFHKKDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHDLIY#issuecomment-579745187>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBFKM7XJ7AB3NEHEZSTRAF43HANCNFSM4KFHKKDA> .