Bamboo 6 and latest Rocket.Chat (0.58) support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected field names in validate
removed fetchPublicRooms() now using chat.postMessage to send the message
|
@jasonfah Do I need to change the README file to say that the server url needs to end with /api/v2 ? |
|
@imclem not sure what you mean. The readme already includes that the user must use /api/v1 (rocket.chat). Unless I missed something. v2 is now the version of the plugin (not api version) |
Didn't got that properly in the first place, it's clear now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4
Quite a few changes. Incremented to v2 as the API URL changed to include /v1.
Has been working well for us running Bamboo v6.0.0 and Rocket.Chat 0.58.
Not sure if this pull request brings across the release but I have a copy of the v2 jar file here;
https://github.com/jasonfah/Bamboo-RocketChat/releases