Support for presets in addition to manual/individual width param #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for presets. Great addition |
| && (src.Value.IndexOf("preset=", StringComparison.InvariantCultureIgnoreCase) > -1)) | ||
| { | ||
| // - get presets from config | ||
| var configSection = WebConfigurationManager.GetSection("resizer") as ImageResizer.ResizerSection; |
There was a problem hiding this comment.
If we're depending on ImageResizer.ResizerSection anyway, it's probably better to just call Config.Current.getConfigXml().queryFirst("presets") so we don't miss elements with case variations. ImageResizer has case-insensitive configuration, unlike the .NET XML library. Copy/paste from https://github.com/imazen/resizer/blob/master/Core/Plugins/Basic/Presets.cs if you want.
ImageResizer also supports the semicolon syntax, not just querystring, so using new Instructions() to parse will enable that. Instructions.Width will return either 'width' and 'w', but not 'maxwidth'. instructions.Get<int>("maxwidth") lets you access that.
There was a problem hiding this comment.
Thanks for the heads up with the semicolon separated instructions! Will fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the filter to use presets if no width given, but a preset parameter. Also updated the readme and switched Visual Studio project configuration to use IIS Express and updated web.config.