Pass image url into data structure to allow logic based on file name #21
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check data.webp for webp support which will allow custom logic for webp enabling (for example disable for explicitly for .gif if we use a lot of gif animations)
|
This is a good change, and makes sense. Could you edit the pull request to merge into the 'unstable' branch? I've been slow to merge pull requests as each one requires a new release and testing, but if I can do a single release for multiple changes that will make things much faster. |
|
Merged under #25 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check data.webp for webp support which will allow custom logic for webp enabling (for example disable for explicitly for .gif if we use a lot of gif animations)