Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually run tests on a big endian architecture on CI #561

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

Shnatsel
Copy link
Contributor

instead of just building on PowerPC and calling it a day

workflow definition is cribbed from image-webp

@Shnatsel
Copy link
Contributor Author

The build fails because dev-dependencies are shared between tests and examples, and one of our examples pulls in glium which in turn pulls in a sprawling dependency tree and ends up missing some headers in cross container.

I guess the best way to work around that is to split the show.rs example into its own crate with its own Cargo.toml and add a separate CI job checking that it still compiles. Any better ideas?

@fintelia
Copy link
Contributor

I'd also be fine just dropping the show example. The majority of it looks like it is about how to use glium to display images rather than anything to do with PNG decoding.

@Shnatsel
Copy link
Contributor Author

I deleted the glium example and that got powerpc CI working. Still passes, too!

@fintelia fintelia merged commit 0a0fba1 into image-rs:master Dec 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants