Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/pie chart section space on html renderer #1327

Merged
merged 2 commits into from
Apr 30, 2023

Conversation

imaNNeo
Copy link
Owner

@imaNNeo imaNNeo commented Apr 30, 2023

There is an issue with Path.combine() in the Flutter when we use HTML renderer,
we use it to handle the sectionsSpace property of PieChartData. We decided to ignore this property when Path.combine() does not work.

More detail on: #955

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #1327 (b7204de) into master (25e318a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
  Coverage   86.02%   86.02%           
=======================================
  Files          45       45           
  Lines        2991     2991           
=======================================
  Hits         2573     2573           
  Misses        418      418           
Impacted Files Coverage Δ
lib/src/chart/pie_chart/pie_chart_painter.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imaNNeo imaNNeo merged commit 8eca901 into master Apr 30, 2023
@imaNNeo imaNNeo deleted the hotfix/pie-chart-section-space-on-html-renderer branch April 30, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant