[10.x] PHP 8.4 Code Compatibility (#53612)

* [10.x] PHP 8.4 Code Compatibility

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

* Apply fixes from StyleCI

* wip

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

---------

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: StyleCI Bot <bot@styleci.io>

Client/Factory.php

@@ -84,7 +84,7 @@ class Factory
      * @param  \Illuminate\Contracts\Events\Dispatcher|null  $dispatcher
      * @return void
      */
-    public function __construct(Dispatcher $dispatcher = null)
+    public function __construct(?Dispatcher $dispatcher = null)
     {
         $this->dispatcher = $dispatcher;
 

Client/PendingRequest.php

@@ -222,7 +222,7 @@ class PendingRequest
      * @param  array  $middleware
      * @return void
      */
-    public function __construct(Factory $factory = null, $middleware = [])
+    public function __construct(?Factory $factory = null, $middleware = [])
     {
         $this->factory = $factory;
         $this->middleware = new Collection($middleware);
@@ -690,7 +690,7 @@ public function beforeSending($callback)
      * @param  callable|null  $callback
      * @return $this
      */
-    public function throw(callable $callback = null)
+    public function throw(?callable $callback = null)
     {
         $this->throwCallback = $callback ?: fn () => null;
 

Client/Pool.php

@@ -36,7 +36,7 @@ class Pool
      * @param  \Illuminate\Http\Client\Factory|null  $factory
      * @return void
      */
-    public function __construct(Factory $factory = null)
+    public function __construct(?Factory $factory = null)
     {
         $this->factory = $factory ?: new Factory();
         $this->handler = Utils::chooseHandler();

Concerns/InteractsWithInput.php

@@ -120,7 +120,7 @@ public function hasAny($keys)
      * @param  callable|null  $default
      * @return $this|mixed
      */
-    public function whenHas($key, callable $callback, callable $default = null)
+    public function whenHas($key, callable $callback, ?callable $default = null)
     {
         if ($this->has($key)) {
             return $callback(data_get($this->all(), $key)) ?: $this;
@@ -198,7 +198,7 @@ public function anyFilled($keys)
      * @param  callable|null  $default
      * @return $this|mixed
      */
-    public function whenFilled($key, callable $callback, callable $default = null)
+    public function whenFilled($key, callable $callback, ?callable $default = null)
     {
         if ($this->filled($key)) {
             return $callback(data_get($this->all(), $key)) ?: $this;
@@ -232,7 +232,7 @@ public function missing($key)
      * @param  callable|null  $default
      * @return $this|mixed
      */
-    public function whenMissing($key, callable $callback, callable $default = null)
+    public function whenMissing($key, callable $callback, ?callable $default = null)
     {
         if ($this->missing($key)) {
             return $callback(data_get($this->all(), $key)) ?: $this;

Exceptions/PostTooLargeException.php

@@ -16,7 +16,7 @@ class PostTooLargeException extends HttpException
      * @param  int  $code
      * @return void
      */
-    public function __construct($message = '', Throwable $previous = null, array $headers = [], $code = 0)
+    public function __construct($message = '', ?Throwable $previous = null, array $headers = [], $code = 0)
     {
         parent::__construct(413, $message, $previous, $headers, $code);
     }

Exceptions/ThrottleRequestsException.php

@@ -16,7 +16,7 @@ class ThrottleRequestsException extends TooManyRequestsHttpException
      * @param  int  $code
      * @return void
      */
-    public function __construct($message = '', Throwable $previous = null, array $headers = [], $code = 0)
+    public function __construct($message = '', ?Throwable $previous = null, array $headers = [], $code = 0)
     {
         parent::__construct(null, $message, $previous, $code, $headers);
     }

RedirectResponse.php

@@ -71,7 +71,7 @@ public function withCookies(array $cookies)
      * @param  array|null  $input
      * @return $this
      */
-    public function withInput(array $input = null)
+    public function withInput(?array $input = null)
     {
         $this->session->flashInput($this->removeFilesFromInput(
             ! is_null($input) ? $input : $this->request->input()

Request.php

@@ -499,7 +499,7 @@ public static function createFromBase(SymfonyRequest $request)
      *
      * @return static
      */
-    public function duplicate(array $query = null, array $request = null, array $attributes = null, array $cookies = null, array $files = null, array $server = null): static
+    public function duplicate(?array $query = null, ?array $request = null, ?array $attributes = null, ?array $cookies = null, ?array $files = null, ?array $server = null): static
     {
         return parent::duplicate($query, $request, $attributes, $cookies, $this->filterFiles($files), $server);
     }