Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure uncompressed ARCs are properly supported #13

Closed
anjackson opened this issue Apr 4, 2014 · 3 comments
Closed

Ensure uncompressed ARCs are properly supported #13

anjackson opened this issue Apr 4, 2014 · 3 comments

Comments

@anjackson
Copy link
Member

So, following on from iipc/openwayback#101, the idea is to test support for uncompressed ARCs from here and try to ensure we can check when this goes wrong.

@anjackson
Copy link
Member Author

Working on a branch of our own repo (ukwa@b45ea54) I've found that the

ArchiveReader reader = ARCReaderFactory.get(fPath, is, false);

approach to firing up the reader always fails. This appears to be because the atFirstRecord == false does not get passed down correctly, and consequently the ARCRecord.parseHeaders method always attempts to read three lines (i.e. like the start of an ARC files) rather than just one.

This seems to be clearly wrong, but it is NOT clear that this is the issue underlying the original problem. This always goes wrong (not just for long offsets), and has nothing to do with seek().

@anjackson
Copy link
Member Author

Modifying the UncompressedARCReader to take the atFirstRecord argument and pass it down in the same way as the CompressedARCReader fixes the test.

anjackson pushed a commit that referenced this issue Jul 7, 2014
avoid pulling in logback, which is wreaking havoc on logging in apps usi...
@johnerikhalse johnerikhalse added this to the 1.1.5 Release milestone Sep 30, 2014
@johnerikhalse
Copy link
Contributor

This fix worked in our environment. Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants