Add srcset attrib rewrite #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. Do we need a 2.4.0 release for this @johnerikhalse? |
|
There isn't a 2.4.0 on the roadmap. As I'd catagorize this as narrow a bug fix, we could release 2.3.1, even with just this one change (and possibly also PR #307). That could probably be done quite quickly. |
|
Even better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
StringTransformerto rewrite URLs insrcsetattributes found in<img>and<source>tags. This will close #310.If you want to use this code, I can update the release notes. If you want me to do that, let me know if you want me to create a new section or put it in 2.3.0 or something else.