Use trimmed filename so readers can infer format. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnerikhalse
added a commit
that referenced
this pull request
Dec 9, 2015
Use trimmed filename so readers can infer format.
johnerikhalse
added a commit
that referenced
this pull request
Dec 9, 2015
|
Thanks, and apologies for forgetting the release note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ResourceFactory implementation takes care to remove any .open extension, so that 'mid-write' WARCs can be used. However, when attempting to parse it uses the original filename, which means the readers cannot infer the format correctly from the extension.
This patch just switched to using the filename without '.open' on the end, and so allows the readers to cope with both compressed and uncompressed archive files.