Fix for issue #51 #199
Merged
Fix for issue #51 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the YEAR_UPPER_LIMIT static final variable, and replaced usages of it with String.valueOf(Calendar.getInstance(TimeZone.getTimeZone("GMT")).get(Calendar.YEAR) )).
This is because if the WayBack instance is up and running over between years. The new year will not be selectable.
- Removed the static definition of the String array months, containing the shorthand name for the months in a year, as it was it was hardcoded to use the english abbreviations.
The new version relies on the default Locale settings to supply the shorthand names.
- Removed the array containing the number of days in each month in the defined year interval 1972 - 2032, and altered the getDaysInMonthBound() to use Calendar directly
instead of relying on the pregenerated array.
- Removed the SSE_1996 variable with SSE_YEAR_LOWER_LIMIT since the start year is no longer hardcoded. The value of the new variable is calculated at Class instansiation
based on the configured start year.
- Altered the dateStrToDate() function. The return value under ParseException must be multiplied by 1000 to convert from the internal second since Epoch to Date() milliseconds.
Also we use SSE_YEAR_LOWER_LIMIT instead of SSE_1996.
- Altered the earliestTimestamp() function to SSE_YEAR_LOWER_LIMIT instead of SSE_1996.
…lass, instead of the hardcoded value of 1996. - In UI-header.jsp, uses the endYear set in the org.archive.wayback.util.Timestamp class to get the current year.
| Set the minimum year that is handled by this server | ||
| --> | ||
| <bean name="minimumYearAlloved" class="org.archive.wayback.util.Timestamp"> | ||
| <property name="startYear" value="1998" /> |
There was a problem hiding this comment.
Shouldn't this default to 1996?
- Added comment for bean to set default start date for "org.archive.wayback.util.Timestamp"
Conflicts: src/site/xdoc/release_notes.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #51
Does probably also fix issue #86.