Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar.jsp produces bad xml #171

Closed
csrster opened this issue Sep 24, 2014 · 3 comments
Closed

Toolbar.jsp produces bad xml #171

csrster opened this issue Sep 24, 2014 · 3 comments
Assignees
@PsypherPunk
Labels
bug
Milestone
2.1.0 Minor Release

Comments

@csrster
Copy link
Contributor

csrster commented Sep 24, 2014

We have been unable to replay m.facebook.com in proxy mode because Toolbar.jsp produces badly formed xml. We have tested a solution which seems to work:

  1. The script body which starts around line 74 needs to be enclosed in a CDATA block because of the
    use of unescaped characters like ">"
  2. The form which starts around line 188 has some unclosed elements.

We'll be happy to submit a patch or pull request.
@csrster
Copy link
Contributor Author

csrster commented Sep 24, 2014

This is actually the root cause of the otherwise mysterious issue #60 .

@kris-sigur kris-sigur mentioned this issue Sep 24, 2014
Closed
@anjackson anjackson added the bug label Sep 25, 2014
@anjackson anjackson added this to the 2.0.1 Release milestone Nov 6, 2014
csrster added a commit to netarchivesuite/openwayback-netarchivesuite that referenced this issue Jan 28, 2015
@csrster
Fix to iipc#171
9292da9 
and iipc#60
csrster added a commit to netarchivesuite/openwayback-netarchivesuite that referenced this issue Jan 28, 2015
@csrster
Updated release notes for:
0ea66f2 
Fix to iipc#171
and iipc#60
@csrster csrster mentioned this issue Jan 28, 2015
Merged
kris-sigur pushed a commit that referenced this issue Jan 29, 2015
Merge pull request #200 from csrster/master
ac174d1 
Fix to #171 (== #60)
@PsypherPunk PsypherPunk self-assigned this Jan 29, 2015
@anjackson
Copy link
Member

okay to close this?

@PsypherPunk
Copy link
Contributor

Fixed in #200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PsypherPunk PsypherPunk

Labels
bug
Projects
None yet
Milestone
2.1.0 Minor Release
Development

No branches or pull requests
3 participants
@anjackson @PsypherPunk @csrster