-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on CI #4
Turn on CI #4
Conversation
@phackstock we need the scenario explorer secrets added to get this going I think |
# Uncomment these two lines for debugging, but leave them commented on 'main' | ||
pull_request: | ||
branches: [ main ] | ||
schedule: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phackstock I think it runs on the default branch (i.e. main) but it is a good question (perhaps it runs on all open PRs...)
Ah good point, on it. |
I'm attempting to fix the failing harmonisation tests now |
Secrets are set. |
@znicholls looks like there's seven CI runs happening, is that on purpose? |
Seven different checks? Yes, I'm just trying to get everything running before I put nightly and WG3 reproduction back on a schedule Or do you mean 7 commits running at once? If yes, that's just cause I don't bother cancelling workflows which failed |
@znicholls, I was referring to the seven different checks, but alright I see then it's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, ready to be merged.
Beauty
…On Thu, 9 Jun 2022 at 2:54 pm, Philip Hackstock ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good to me, ready to be merged.
—
Reply to this email directly, view it on GitHub
<#4 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFUH5GZHUYV6WSLADBQ4N43VOHSR5ANCNFSM5YJID6BQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closes #3
The SR1.5 running tests are removed as they require a MAGICC configuration file that was only used for testing and we don't want to include in the repository because it's not related to reproducing WG3 (it was a sensitivity thing that we no longer need)