Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on CI #4

Merged
merged 8 commits into from
Jun 9, 2022
Merged

Turn on CI #4

merged 8 commits into from
Jun 9, 2022

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Jun 9, 2022

Closes #3

The SR1.5 running tests are removed as they require a MAGICC configuration file that was only used for testing and we don't want to include in the repository because it's not related to reproducing WG3 (it was a sensitivity thing that we no longer need)

@znicholls
Copy link
Collaborator Author

@phackstock we need the scenario explorer secrets added to get this going I think

@znicholls znicholls mentioned this pull request Jun 9, 2022
5 tasks
# Uncomment these two lines for debugging, but leave them commented on 'main'
pull_request:
branches: [ main ]
schedule:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phackstock I think it runs on the default branch (i.e. main) but it is a good question (perhaps it runs on all open PRs...)

@phackstock
Copy link
Contributor

@phackstock we need the scenario explorer secrets added to get this going I think

Ah good point, on it.

@znicholls
Copy link
Collaborator Author

I'm attempting to fix the failing harmonisation tests now

@phackstock
Copy link
Contributor

Secrets are set.

@phackstock
Copy link
Contributor

@znicholls looks like there's seven CI runs happening, is that on purpose?

@znicholls
Copy link
Collaborator Author

znicholls commented Jun 9, 2022

@znicholls looks like there's seven CI runs happening, is that on purpose?

Seven different checks? Yes, I'm just trying to get everything running before I put nightly and WG3 reproduction back on a schedule

Or do you mean 7 commits running at once? If yes, that's just cause I don't bother cancelling workflows which failed

@phackstock
Copy link
Contributor

@znicholls, I was referring to the seven different checks, but alright I see then it's fine.

@znicholls znicholls marked this pull request as ready for review June 9, 2022 11:39
@znicholls znicholls requested a review from phackstock June 9, 2022 11:40
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, ready to be merged.

@znicholls
Copy link
Collaborator Author

znicholls commented Jun 9, 2022 via email

@znicholls znicholls merged commit e66d985 into main Jun 9, 2022
@znicholls znicholls deleted the 3-turn-on-ci branch June 9, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic CI
2 participants