Skip to content

Commit

Permalink
A couple of ARM64-related fixes (prometheus#934)
Browse files Browse the repository at this point in the history
* Do not rely on AArch64 CPUs to support 32-bit ARM for cross-testing.

Signed-off-by: Alexey Kopytov <akopytov@gmail.com>

* aarch64 like ppc64le reports 64k node_sockstat_TCP_mem_bytes due to 64k pages.

Signed-off-by: Alexey Kopytov <akopytov@gmail.com>
  • Loading branch information
akopytov authored and discordianfish committed May 14, 2018
1 parent 84dc362 commit dd98a09
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
9 changes: 5 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,12 @@ else
test-e2e := skip-test-e2e
endif

e2e-out = collector/fixtures/e2e-output.txt
ifeq ($(MACH), ppc64le)
e2e-out = collector/fixtures/e2e-ppc64le-output.txt
else
e2e-out = collector/fixtures/e2e-output.txt
e2e-out = collector/fixtures/e2e-64k-page-output.txt
endif
ifeq ($(MACH), aarch64)
e2e-out = collector/fixtures/e2e-64k-page-output.txt
endif

# 64bit -> 32bit mapping for cross-checking. At least for amd64/386, the 64bit CPU can execute 32bit code but not the other way around, so we don't support cross-testing upwards.
Expand All @@ -68,7 +70,6 @@ endef

# By default, "cross" test with ourselves to cover unknown pairings.
$(eval $(call goarch_pair,amd64,386))
$(eval $(call goarch_pair,arm64,arm))
$(eval $(call goarch_pair,mips64,mips))
$(eval $(call goarch_pair,mips64el,mipsel))

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion end-to-end-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ skip_re="^(go_|node_exporter_build_info|node_scrape_collector_duration_seconds|p
arch="$(uname -m)"

case "${arch}" in
ppc64le) fixture='collector/fixtures/e2e-ppc64le-output.txt' ;;
aarch64|ppc64le) fixture='collector/fixtures/e2e-64k-page-output.txt' ;;
*) fixture='collector/fixtures/e2e-output.txt' ;;
esac

Expand Down

0 comments on commit dd98a09

Please sign in to comment.