Refactor/py pkg update #39

saalUW · 2024-04-22T21:41:39Z

Added:

py-pkg format files (ruff, doc build, etc.) // pyDisagg specific info is missing
pre-config.yaml file // current implementation means the user has to pip install pre-config and run in the pydisagg directory
init file to age_split

Updated:

init file
build.yml // updated install and run steps, added filepath to ensure pydisagg venv is being called for the test
pyproject // changed setup.cfg to match pyproject standards

Removed:

setup.cfg / .py
sphinx directory

py-pkg files are not edited for pyDisagg yet

Updated innit for easier calling Commented out unused functions but kept them incase I am missing use case Need to write test for split_datapoint Returned object for split_rate_jacobian but unsure if this is correct

Still getting used to running Ruff, doesn't seem to want to function in the terminal and the VS code extension isn't formatting all so i went through the src files manually and Ctrl + S them ... can we review when you're back?

Trying pre-commit

forgot to remove lint.yml

pip installed ruff and re-ran the format to include the 3 I was missing

previous version was crashing for me so hopefully this change fixes it

I re-ran the code with the update on an R file and it seemed to load in correctly. Notable changes are not specifying sphinx, and pytest.

added pytest options

import pydisagg.transformations as tr E ModuleNotFoundError: No module named 'pydisagg'

pyproject.toml

src/pydisagg/age_split/__init__.py

src/pydisagg/models.py

src/pydisagg/preprocess.py

zhengp0

Thanks very much @saalUW!! This is looking better and better! I left some minor comments, take a look when you get a chance.

Chnaged license corrected github url removed dev_dependencies from build removed init code from age_split sub directory ruff formatted files numpy format for doc in preprocess

zhengp0

Thanks @saalUW! This looks good!

saalUW and others added 16 commits April 18, 2024 15:33

added py-pkg files and updated age_split to have innit

14ce469

py-pkg files are not edited for pyDisagg yet

Solved lint errors

838f6c1

Updated innit for easier calling Commented out unused functions but kept them incase I am missing use case Need to write test for split_datapoint Returned object for split_rate_jacobian but unsure if this is correct

Black formatting

c7f04a8

Still getting used to running Ruff, doesn't seem to want to function in the terminal and the VS code extension isn't formatting all so i went through the src files manually and Ctrl + S them ... can we review when you're back?

Create .pre-commit-config.yaml

71e67f6

Trying pre-commit

Delete lint.yml

c5c5bc1

forgot to remove lint.yml

installed ruff and formatted all the docs

fee1a55

pip installed ruff and re-ran the format to include the 3 I was missing

Update .pre-commit-config.yaml

6549e5d

previous version was crashing for me so hopefully this change fixes it

remove old sphinx folder now we have docs

18e4165

Updated the pyproject file

fe1ccf8

I re-ran the code with the update on an R file and it seemed to load in correctly. Notable changes are not specifying sphinx, and pytest.

Included pytest so that it builds correctly

dce9422

added pytest options

Trying again

20b0d8a

Update build to see if this solves pytest import

ae39e5e

Update build to have dependencies

ac53839

Removed [dev]

3a74353

Include python path to see if virtenv will include pydisagg to test

9baa266

import pydisagg.transformations as tr E ModuleNotFoundError: No module named 'pydisagg'

Added /src to find local venv

3d74623

saalUW added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 22, 2024

saalUW requested a review from zhengp0 April 22, 2024 21:41

saalUW self-assigned this Apr 22, 2024