Added video playback offset support for MCAP logs #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainBertrand
requested changes
Feb 20, 2024
...jfx/src/main/java/us/ihmc/scs2/sessionVisualizer/jfx/session/mcap/FFMPEGVideoDataReader.java
Outdated
Show resolved
Hide resolved
…timestamp to nanoseconds, clean up logic for not reading redundant frames.
SylvainBertrand
approved these changes
Feb 27, 2024
* Added controls for cropping log file * WIP: Working on a new MCAP cropper * Dense commit: Split up MCAP and added LZ4 frame encoder * Implementing tools to write MCAP back to file. * Refactored the LZ4 output stream to work with byte buffers * WIP * wip * WIP: More stuff for cropping * Some doc, started writing up a test using the demo MCAP file. * Improving the test. * Making progress on the test. * WIP: Tracking down chunk writing/reading bug. * WIP: Got the cropping test to pass. Still needs a few final checks * Wrapped up the cropping * MCAP cropping is working.
…timestamp to nanoseconds, clean up logic for not reading redundant frames.
…feature/mcap-video-offset
… stored timestamp to nanoseconds, clean up logic for not reading redundant frames." This reverts commit 6f15652.
…timestamp to nanoseconds, clean up logic for not reading redundant frames.
|
Sounds good, merging (had a small git issue in the revert commit, but it's fixed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a JavaFX Spinner under each thumbnail to specify an offest between the MCAP start and the video playback start. The offset increments in milliseconds and can be positive or negative.