-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add historical changes support for the Editor #7779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ihhub, I tested the undo/redo feature and I like how it works. It could be easily used for all new editor actions.
I only found one issue with the radar update on undo/redo and left a couple of comments about it. Could you please check them when you have time.
Also currently we can make the unlimited number of undo history records. Maybe we should limit the history manager maximum size to, in example, 100 records. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ihhub I just left a few questions, could you please take a look when you have time?
Hi @oleg-derevenetz and @Districh-ru , I've added a limit for actions as 500: average value from both of you :) |
SonarCloud Quality Gate failed.
|
relates to #6845
fheroes2.engine.version_.1.0.8.2023-09-19.23-23-55.mp4
This PR also fixes rare flickering on a first load of a new map in the Editor:
fheroes2.engine.version_.1.0.8.2023-09-20.14-20-33.mp4