Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup for Maps::Tiles #7762

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Code cleanup for Maps::Tiles #7762

merged 2 commits into from
Sep 16, 2023

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Sep 16, 2023

Rename some cryptic functions and variables.

relates to #6845

Rename some cryptic functions and variables.

relates to #6845
@ihhub ihhub added the improvement New feature, request or improvement label Sep 16, 2023
@ihhub ihhub added this to the 1.0.9 milestone Sep 16, 2023
@ihhub ihhub self-assigned this Sep 16, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

@ihhub ihhub requested a review from Districh-ru September 16, 2023 06:14
Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihhub . I left one comment regarding functions naming. Could you please take a look when you have time.

@ihhub ihhub requested a review from Districh-ru September 16, 2023 15:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.8% 2.8% Duplication

@ihhub ihhub merged commit 6c040c7 into master Sep 16, 2023
@ihhub ihhub deleted the maps-tiles-cleanup branch September 16, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants